google spreadsheet - Javascript look-up function optimization -

-

i'm writing custom function google sheet using javascript, should return value based upon table.

i've got works, feels extremely ugly lots of nested if statements. how improved readability?

function price(msrp, order_quantity)  {   var percentage;   if(order_quantity >= 200 && order_quantity <= 400) {     if(msrp >=49 && msrp <= 99) {       percentage = 0.07;     } else if (msrp >=100 && msrp <= 249) {       percentage = 0.06;     } else if (msrp >=250 && msrp <= 499) {       percentage = 0.05;     } else if (msrp >=500) {       percentage = 0.04;     } else {       return null;     }   } else if (order_quantity >= 500 && order_quantity <= 900)  {     if(msrp >=49 && msrp <= 99) {       percentage = 0.06;     } else if (msrp >=100 && msrp <= 249) {       percentage = 0.05;     } else if (msrp >=250 && msrp <= 499) {       percentage = 0.04;     } else if (msrp >=500) {       percentage = 0.03;     } else {       return null;     }   } else if (order_quantity >= 1000 && order_quantity <= 1400)  {     if(msrp >=49 && msrp <= 99) {       percentage = 0.07;     } else if (msrp >=100 && msrp <= 249) {       percentage = 0.06;     } else if (msrp >=250 && msrp <= 499) {       percentage = 0.05;     } else if (msrp >=500) {       percentage = 0.04;     } else {       return null;     }   } else if (order_quantity >= 1500)  {     if(msrp >=49 && msrp <= 99) {       percentage = 0.04;     } else if (msrp >=100 && msrp <= 249) {       percentage = 0.03;     } else if (msrp >=250 && msrp <= 499) {       percentage = 0.025;     } else if (msrp >=500) {       percentage = 0.015;     } else {       return null;     }   } else {     return null;   }   return msrp * percentage; }

you define of levels in arrays , use instance array.filter:

function price (msrp, order_quantity) {     var percentagelevels = [                 [0.07, 0.06, 0.05, 0.04],                 [0.06, 0.05, 0.04, 0.03],                 [0.04, 0.03, 0.025, 0.015]             ],             quantitylevels = [                 { min: 200, max: 400, percentages: percentagelevels[0] },                 { min: 500, max: 900, percentages: percentagelevels[1] },                 { min: 1000, max: 1400, percentages: percentagelevels[0] },                 { min: 1500, max: number.max_value, percentages: percentagelevels[2] }             ],             msrplevels = [                 { min: 49, max: 99 },                 { min: 100, max: 249 },                 { min: 250, max: 499 },                 { min: 500, max: number.max_value }             ],             percentages = (quantitylevels.filter(function (q) {                 return q.min <= order_quantity && order_quantity <= q.max;             })[0] || {}).percentages,             foundmsrp = percentages ? msrplevels.filter(function (m, i) {                 msrplevels[i].percentage = percentages[i];                  return m.min <= msrp && msrp <= m.max;             })[0] : null;      if (!percentages || !foundmsrp) {         return null;     }      return msrp * foundmsrp.percentage; };

the call quantitylevels.filter() find quantitylevel order_quantity falls into, if any, , call msprlevels.filter() maps percentage value each msprlevel , returns level matches know if foundmspr has value foundmspr.percentage has percentage multiplier want.


Comments

Post a Comment

Popular posts from this blog

Spring Boot + JPA + Hibernate: Unable to locate persister -

-
i trying work entity inside request method of spring boot application. entity in project , pom.xml has dependencies it. why error message?: org.hibernate.unknownentitytypeexception: unable locate persister: com.ric.bill.model.bs.par package com.ric.web; import java.util.concurrent.atomic.atomiclong; import javax.persistence.entitymanager; import javax.persistence.persistencecontext; import net.sf.ehcache.cachemanager; import net.sf.ehcache.management.cache; import net.sf.ehcache.management.cachestatistics; import org.hibernate.stat.statistics; import org.springframework.beans.factory.annotation.autowired; import org.springframework.boot.autoconfigure.domain.entityscan; import org.springframework.cache.annotation.enablecaching; import org.springframework.transaction.annotation.enabletransactionmanagement; import org.springframework.transaction.annotation.propagation; import org.springframework.transaction.annotation.transactional; import org.springframework.web.bind.annotati
Read more

go - Golang: panic: runtime error: invalid memory address or nil pointer dereference using bufio.Scanner -

-
i implementing go program uses bufio.scanner , bufio.writer have packaged code follows package main import ( "fmt" "player/command" "strings" ) func main() { //enter code here. read input stdin. print output stdout commands.scanner.scan() { //scan new line , send comand variable check command exist or not input := strings.split(strings.trim(commands.scanner.text(), " "), " ") command := input[0] if command == "" { fmt.printf("$ %s:", commands.pwd) continue } if !commands.commands[command] { commands.throwerror("cannot recognize input.") } else { commands.execute(command, input[1:], nil) } fmt.printf("$ %s:", commands.pwd) } } i using init.go file in main package follows package main import ( "flag" "player/sourc
Read more

c - double free or corruption (fasttop) -

-
this code reads null terminated string file (file containing null terminated strings & should provide index wanted string). error: *** error in `./main': double free or corruption (fasttop): 0x090a4a80 *** aborted code: char *tmp_realloc=null; char *sstring=null; int i=1; /*set file pointer point string*/ fseek(fh,index,seek_set); sstring=(char*)malloc(sizeof(char)); if(sstring == null) return null; tmp_realloc=sstring; while( (*(sstring+i-1)=(char)fgetc((file*)fh)) != 0x0 ) { /*reallocate more memory*/ tmp_realloc=(char*)realloc((char*)sstring,++i); /*if not same address copy old new & set old point new*/ if(tmp_realloc != sstring){ strcpy((char*)tmp_realloc,(char*)sstring); free(sstring); sstring=tmp_realloc; } } could tell me pointer causing issue (& reason) ? remove part /*if not same address copy old new & set old point new*/ if(tmp_realloc != sstring){ strc
Read more