cppcheck - stumbling upon a non-trivial bool scenario in C++ -

-

when cppcheck runs on code,[1] complains error:

void bool_express(bool apre, bool ax, bool apost) {     bool x;     const bool pre = apre;     if (pre) {         x = ax;     }     const bool post = apost;      // error checking passage of original code:     if ( !pre || !x || !post ) {         if ( !pre ) {             trace("pre failed");         } else if ( !x ) {       // <-- here cppcheck complains             trace("x failed");         } else {             trace("post failed");         }     } else {         // success passage of original code:         trace("ok");     } }

this message, makes me nervous:

id: uninitvar summary: uninitialized variable: x message: uninitialized variable: x

i think it's false positive, admit may not obvious. nevertheless don't want touch code, because it's old , lot heavier extracted version.

have ever experienced situations this? how deal it?

[1] code reduced bones, original code establishes precondition (pre), (x), forces postcondition (post), after that, error conditions checked. transformed runtime-results of functions called , stored in pre, x, , post 3 arguments of test case.

it false positive in cppcheck. solved adding inline suppression:[1]

    if ( !pre ) {         trace("pre failed");     // cppcheck-suppress uninitvar     } else if ( !x ) {         trace("x failed");     } else {         trace("post failed");     }

and brought attention of cppcheck developers:

#7663 (false positive: uninitialised variable in unreachable code)

[1] decided not initialize variable. not performance reasons, informed bug being fixed in future release, when cppcheck say

id: unmatchedsuppression summary: unmatched suppression: uninitvar message: unmatched suppression: uninitvar

Comments

Post a Comment

Popular posts from this blog

Spring Boot + JPA + Hibernate: Unable to locate persister -

-
i trying work entity inside request method of spring boot application. entity in project , pom.xml has dependencies it. why error message?: org.hibernate.unknownentitytypeexception: unable locate persister: com.ric.bill.model.bs.par package com.ric.web; import java.util.concurrent.atomic.atomiclong; import javax.persistence.entitymanager; import javax.persistence.persistencecontext; import net.sf.ehcache.cachemanager; import net.sf.ehcache.management.cache; import net.sf.ehcache.management.cachestatistics; import org.hibernate.stat.statistics; import org.springframework.beans.factory.annotation.autowired; import org.springframework.boot.autoconfigure.domain.entityscan; import org.springframework.cache.annotation.enablecaching; import org.springframework.transaction.annotation.enabletransactionmanagement; import org.springframework.transaction.annotation.propagation; import org.springframework.transaction.annotation.transactional; import org.springframework.web.bind.annotati
Read more

go - Golang: panic: runtime error: invalid memory address or nil pointer dereference using bufio.Scanner -

-
i implementing go program uses bufio.scanner , bufio.writer have packaged code follows package main import ( "fmt" "player/command" "strings" ) func main() { //enter code here. read input stdin. print output stdout commands.scanner.scan() { //scan new line , send comand variable check command exist or not input := strings.split(strings.trim(commands.scanner.text(), " "), " ") command := input[0] if command == "" { fmt.printf("$ %s:", commands.pwd) continue } if !commands.commands[command] { commands.throwerror("cannot recognize input.") } else { commands.execute(command, input[1:], nil) } fmt.printf("$ %s:", commands.pwd) } } i using init.go file in main package follows package main import ( "flag" "player/sourc
Read more

c - double free or corruption (fasttop) -

-
this code reads null terminated string file (file containing null terminated strings & should provide index wanted string). error: *** error in `./main': double free or corruption (fasttop): 0x090a4a80 *** aborted code: char *tmp_realloc=null; char *sstring=null; int i=1; /*set file pointer point string*/ fseek(fh,index,seek_set); sstring=(char*)malloc(sizeof(char)); if(sstring == null) return null; tmp_realloc=sstring; while( (*(sstring+i-1)=(char)fgetc((file*)fh)) != 0x0 ) { /*reallocate more memory*/ tmp_realloc=(char*)realloc((char*)sstring,++i); /*if not same address copy old new & set old point new*/ if(tmp_realloc != sstring){ strcpy((char*)tmp_realloc,(char*)sstring); free(sstring); sstring=tmp_realloc; } } could tell me pointer causing issue (& reason) ? remove part /*if not same address copy old new & set old point new*/ if(tmp_realloc != sstring){ strc
Read more